DPE-2424 Update rock version to 8.0.34 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayancanonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
taurus-forever
approved these changes
Aug 28, 2023
|
Tests are failing because of some tox target related changes in https://github.com/canonical/mysql-k8s-operator/pull/273/files. Should the ROCK still be running integration tests of the K8s charm? |
looks like it's using the wrong tox environment IMO this is why we shouldn't copy integration tests over to this repo—the integration tests should live in mysql-k8s |
|
Potential alternative solution: release to "branch" and test with pr in mysql-k8s-operator |
carlcsaposs-canonical
approved these changes
Aug 28, 2023
paulomach
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We updated the
charmed-mysqlsnap (revision 69) in8.0/edgeto be v8.0.34. Rebuilding the rock will tag the wrong versionsSolution
Update version tag to 8.0.34